Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use Poetry 1.7.1 #207

Merged
merged 1 commit into from
May 15, 2024
Merged

build: Use Poetry 1.7.1 #207

merged 1 commit into from
May 15, 2024

Conversation

l0b0
Copy link
Collaborator

@l0b0 l0b0 commented May 28, 2023

Upgrades to 1.8 are blocked by a Conda issue.

Blocked by pypa/pip#11394, which should be part of the next pip release, >23.2.1.

Jimlinz
Jimlinz previously approved these changes May 28, 2023
@Jimlinz
Copy link

Jimlinz commented May 28, 2023

Looks like it is still failing though...

@l0b0
Copy link
Collaborator Author

l0b0 commented May 31, 2023

Looks like it is still failing though...

Yep, Poetry still doesn't work on Windows. Reported upstream. Upstream issue: Ignore errors in temporary directory cleanup

Update: Reverted the Windows-related change, so that we can at least upgrade.

@l0b0 l0b0 marked this pull request as draft June 8, 2023 01:36
@l0b0 l0b0 force-pushed the build/use-latest-poetry branch from c0e4091 to 488fef1 Compare June 8, 2023 22:05
@l0b0 l0b0 force-pushed the build/use-latest-poetry branch 2 times, most recently from 7e03a10 to e15a407 Compare June 22, 2023 02:22
@l0b0 l0b0 marked this pull request as ready for review June 22, 2023 02:22
@l0b0 l0b0 requested a review from Jimlinz June 22, 2023 02:24
@l0b0 l0b0 force-pushed the build/use-latest-poetry branch 2 times, most recently from b25f349 to 9aba6f1 Compare July 19, 2023 01:41
@l0b0 l0b0 marked this pull request as draft July 19, 2023 01:41
@kodiakhq kodiakhq bot removed the automerge label Aug 17, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 17, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@l0b0 l0b0 force-pushed the build/use-latest-poetry branch 6 times, most recently from 998ea9f to ae5b8f2 Compare May 14, 2024 03:33
@l0b0 l0b0 force-pushed the build/use-latest-poetry branch from ae5b8f2 to 33c90c4 Compare May 14, 2024 04:12
@l0b0 l0b0 force-pushed the build/use-latest-poetry branch from 33c90c4 to b8621d5 Compare May 15, 2024 21:43
@l0b0 l0b0 changed the title build: Use latest Poetry build: Use Poetry 1.7.1 May 15, 2024
@l0b0 l0b0 marked this pull request as ready for review May 15, 2024 21:55
@l0b0 l0b0 enabled auto-merge (rebase) May 15, 2024 21:58
@l0b0 l0b0 merged commit 487575f into master May 15, 2024
20 checks passed
@l0b0 l0b0 deleted the build/use-latest-poetry branch May 15, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants